unify the SDC integrator code paths #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we never use this and it doesn't seem like it will be needed since we've made so many improvements to the integrators.
this will make it easier to merge a lot of integrator logic
…into common_integrators
zingale
changed the title
zingale
changed the title
yut23
reviewed
May 29, 2024
integration/integrator_setup_sdc.H
Outdated
Comment on lines
58
to
59
| // we use 1-based indexing inside of the integrator, so we need to | ||
| // shift the indices SRHO, SFS, etc by 1 |
There was a problem hiding this comment.
I don't think this comment applies anymore
There was a problem hiding this comment.
indeed, you are right. I think that's from back when the tolerances were arrays
There was a problem hiding this comment.
The manual indexing was removed in #1039
yut23
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a lot of the redundancy in the various actual_integrator_sdc.H files