add docs on Jacobian caching #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
blocked by #1559 |
zhichen3
reviewed
May 24, 2024
| can be disabled at runtime by setting ``integrator.use_jacobian_caching = 0``. | ||
|
|
||
| On GPUs, we disable Jacobian caching due to the increased memory needs. This | ||
| is disabled at compile-time via the build parameter ``USE_JACOBIAN_CACHING``. |
There was a problem hiding this comment.
Its currently only disabled by default for CUDA I think? Should we change that?
Also I think you mean "disabled by default but can be enabled at compile-time via USE_JACOBIAN_CACHING=TRUE "
There was a problem hiding this comment.
you're right. I've fixed that.
|
that's a good point -- maybe that explains why HIP performance is not as good as CUDA? |
|
addressing the CUDA-specific part in #1564 |
zhichen3
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.