add the ability print warnings from GPU #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is enabled with USE_GPU_PRINTF
zingale
changed the title
|
I've tested this with CUDA and it seems to work. For Castro, we'll probably want to add a flush after the burner call once this is in. |
zhichen3
reviewed
Jul 25, 2024
| @@ -35,6 +35,10 @@ endif | |||
| # Require C++17 | |||
| CXXSTD := c++17 | |||
|
|
|||
| ifeq ($(USE_GPU_PRINTF),TRUE) | |||
There was a problem hiding this comment.
is it necessary to make sure this can be turned on only when we use GPU?
There was a problem hiding this comment.
I don't think so, since it should only be used in an #elif on #ifndef AMREX_USE_GPU, but I can add it just to be safe
zhichen3
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is enabled with USE_GPU_PRINTF