Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up interpolation routines in AMReX_TracerParticle_mod_K.H and AMReX_Particle_mod_K.H #3679

Merged
merged 19 commits into from
Jan 20, 2024

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Dec 19, 2023

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers changed the title [WIP Generalize mac_interpolate and cic_interpolate for non-uniform cell spacing [WIP] Generalize mac_interpolate and cic_interpolate for non-uniform cell spacing Dec 19, 2023
@atmyers atmyers changed the title [WIP] Generalize mac_interpolate and cic_interpolate for non-uniform cell spacing [WIP] Clean up interpolation routines in AMReX_TracerParticle_mod_K.H and AMReX_Particle_mod_K.H Jan 18, 2024
@atmyers atmyers changed the title [WIP] Clean up interpolation routines in AMReX_TracerParticle_mod_K.H and AMReX_Particle_mod_K.H Clean up interpolation routines in AMReX_TracerParticle_mod_K.H and AMReX_Particle_mod_K.H Jan 18, 2024
@atmyers atmyers marked this pull request as ready for review January 18, 2024 22:59

//
// cic_interpolate computes the velocity at the particle by interpolating from velocity
Copy link
Contributor

@RevathiJambunathan RevathiJambunathan Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be any co-located cell-centered field. not just velocity?
should we change uarr to mfarr, of just field_arr?

Copy link
Contributor

@RevathiJambunathan RevathiJambunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. thank you for this PR!

Src/Particle/AMReX_TracerParticle_mod_K.H Outdated Show resolved Hide resolved
Src/Particle/AMReX_TracerParticle_mod_K.H Outdated Show resolved Hide resolved
Src/Particle/AMReX_TracerParticle_mod_K.H Outdated Show resolved Hide resolved
Src/Particle/AMReX_TracerParticle_mod_K.H Outdated Show resolved Hide resolved
Src/Particle/AMReX_TracerParticle_mod_K.H Outdated Show resolved Hide resolved
Src/Particle/AMReX_TracerParticle_mod_K.H Outdated Show resolved Hide resolved
Src/Particle/AMReX_TracerParticle_mod_K.H Outdated Show resolved Hide resolved
Src/Particle/AMReX_TracerParticle_mod_K.H Outdated Show resolved Hide resolved
Src/Particle/AMReX_TracerParticle_mod_K.H Outdated Show resolved Hide resolved
Src/Particle/AMReX_TracerParticle_mod_K.H Outdated Show resolved Hide resolved
@atmyers atmyers enabled auto-merge (squash) January 19, 2024 01:06
@atmyers atmyers merged commit 4be4050 into AMReX-Codes:development Jan 20, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants