New Linear Solver: Curl of Curl #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
WeiqunZhang
force-pushed
the
curl_curl
branch
4 times, most recently
from
77ec6db to
a0da8cc
Compare
|
I’m happy to see this PR. Can we please swap the labeling of alpha and beta to match the existing conventions with the ABec solvers? 🙏 i.e., make it alpha E + curl (beta curl E) = rhs The beta coefficient has always been for the derivative term and alpha for the non-derivative term. |
|
Will discuss this with Justin who gave me the equation. |
WeiqunZhang
force-pushed
the
curl_curl
branch
3 times, most recently
from
7bbcd34 to
71cb2b1
Compare
eebasso
reviewed
Jan 17, 2024
WeiqunZhang
force-pushed
the
curl_curl
branch
2 times, most recently
from
adbb796 to
83ddb78
Compare
WeiqunZhang
force-pushed
the
curl_curl
branch
from
83ddb78 to
3a8ce86
Compare
|
This is ready for review. We still need to try different restriction and smoothing strategies. But that could be left to the future. More specifically, in stead of simple injection, I want to try weighted averaging like what we do for the nodal solver. That makes the restriction operator more consistent with prolongation. |
WeiqunZhang
force-pushed
the
curl_curl
branch
from
3a8ce86 to
4feed1e
Compare
Add a new linear solver for curl (alpha curl E) + beta E = rhs in 2D & 3D, where E is an array of 3 MultiFabs on edges, and alpha and beta are scalars. It supports periodic, homogeneous Dirichlet, and symmetry boundaries. At the symmetry boundary, the normal component changes the sign, whereas the transverse components do not.
WeiqunZhang
force-pushed
the
curl_curl
branch
from
4feed1e to
8f77828
Compare
|
I'll take a look. Attn for review if you like: @dpgrote @JustinRayAngus @debog @RemiLehe :) |
ax3l
approved these changes
Feb 2, 2024
Co-authored-by: Axel Huebl <[email protected]>
Co-authored-by: Axel Huebl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new linear solver for curl (alpha curl E) + beta E = rhs in 2D & 3D,
where E is an array of 3 MultiFabs on edges, and alpha and beta are
scalars. It supports periodic, homogeneous Dirichlet, and symmetry
boundaries. At the symmetry boundary, the normal component changes the sign,
whereas the transverse components do not.