Disable optimization for computeRoundOffDomain #3685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears dangerous to have optimization on when compiling the Geometry::computeRoundOffDomain function. In the past, we had to change the source code for Intel compilers. Recently, there appears to be issues with ROCm 6.0 when optimization is on. Thus, we disable optimization for that function. Inline functions outsideRoundoffDomain and insideRoundoffDomain.
|
The issue appears to be integer overflow not really this function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears dangerous to have optimization on when compiling the Geometry::computeRoundOffDomain function. In the past, we had to change the source code for Intel compilers. Recently, there appears to be issues with ROCm 6.0 when optimization is on. Thus, we disable optimization for that function.
Inline functions outsideRoundoffDomain and insideRoundoffDomain.