Add a linspace-like function in AMReX_Algorithm.H #3698
Conversation
|
Hello everyone. Do you think that it could be interesting to offer this function in AMReX ? |
|
I think such a function is useful. I wonder if we should make sure that both |
Src/Base/AMReX_Algorithm.H
Outdated
| const std::ptrdiff_t count = last-first; | ||
| if (count >= 2){ | ||
| const auto delta = (stop - start)/(count - 1); | ||
| for (int i = 0; i < count-1; ++i){ |
There was a problem hiding this comment.
Could use std::ptrdiff_t instead of int.
There was a problem hiding this comment.
It's a good idea. I've replaced int with std::ptrdiff_t
I agree! It seems to work, although the syntax is quite verbose! |
Src/Base/AMReX_Algorithm.H
Outdated
| @@ -208,6 +208,22 @@ namespace amrex | |||
| #endif | |||
| } | |||
|
|
|||
| template<typename ItType, typename ValType, | |||
| typename std::enable_if<std::is_floating_point<typename ItType::value_type>::value,int>::type = 0, | |||
There was a problem hiding this comment.
I think we need to use iterator_traits otherwise raw pointers would not work as ItType.
We could also combine the two enable_ifs into one.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for the link. This version uses iterator_traits and combines the two enable_if
## Summary Similarly to what was done in #3698, I would like to propose to add a `logspace-like` function in `AMReX_Algorithm.H`. Indeed, filling a container with logarithmically spaced numbers occurs rather frequently. This PR proposes a possible implementation. As for `linspace`, the container is modified (in place) only if it has at least 2 elements. ## Additional background ## Checklist The proposed changes: - [ ] fix a bug or incorrect behavior in AMReX - [X] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
Summary
I would like to propose to add a linspace-like function in AMReX_Algorithm.H , since filling a container with equally spaced numbers is a task that occurs rather frequently. This PR proposes a possible implementation.
The container is modified in place only if it has at least 2 elements.
Additional background
Checklist
The proposed changes: