Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robin BC: Abort if solver is not safe for reuse #3788

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Robin BC: Abort if solver is not safe for reuse #3788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fd3e6d
Robin BC: Abort if solver is reused
WeiqunZhang Mar 5, 2024
eb5cf73
Robin BC: Reuse if we can
WeiqunZhang Mar 5, 2024
75aaa94
To reuse ABecLap with Robin BC, call applyRobinBCTermsCoeffs in
cgilet Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions Src/LinearSolvers/MLMG/AMReX_MLABecLaplacian.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,9 @@ public:
Vector<Vector<MF> > m_a_coeffs;
Vector<Vector<Array<MF,AMREX_SPACEDIM> > > m_b_coeffs;

bool m_scalars_set = false;
bool m_acoef_set = false;

protected:

bool m_needs_update = true;
Expand Down Expand Up @@ -308,7 +311,9 @@ MLABecLaplacianT<MF>::setScalars (T1 a, T2 b) noexcept
for (int amrlev = 0; amrlev < this->m_num_amr_levels; ++amrlev) {
m_a_coeffs[amrlev][0].setVal(RT(0.0));
}
m_acoef_set = true;
}
m_scalars_set = true;
}

template <typename MF>
Expand All @@ -323,6 +328,7 @@ MLABecLaplacianT<MF>::setACoeffs (int amrlev, const AMF& alpha)
"MLABecLaplacian::setACoeffs: alpha is supposed to be single component.");
m_a_coeffs[amrlev][0].LocalCopy(alpha, 0, 0, 1, IntVect(0));
m_needs_update = true;
m_acoef_set = true;
}

template <typename MF>
Expand All @@ -333,6 +339,7 @@ MLABecLaplacianT<MF>::setACoeffs (int amrlev, T alpha)
{
m_a_coeffs[amrlev][0].setVal(RT(alpha));
m_needs_update = true;
m_acoef_set = true;
}


Expand Down Expand Up @@ -402,6 +409,8 @@ MLABecLaplacianT<MF>::update ()
applyMetricTermsCoeffs();
#endif

applyRobinBCTermsCoeffs();

averageDownCoeffs();

update_singular_flags();
Expand Down Expand Up @@ -488,6 +497,14 @@ void applyRobinBCTermsCoeffs (LP& linop)
}
const RT bovera = linop.m_b_scalar/linop.m_a_scalar;

if (!reset_alpha) {
AMREX_ALWAYS_ASSERT_WITH_MESSAGE(linop.m_scalars_set && linop.m_acoef_set,
"To reuse solver With Robin BC, one must re-call setScalars (and setACoeffs if the scalar is not zero)");
}

linop.m_scalars_set = false;
linop.m_acoef_set = false;

for (int amrlev = 0; amrlev < linop.NAMRLevels(); ++amrlev) {
const int mglev = 0;
const Box& domain = linop.Geom(amrlev,mglev).Domain();
Expand Down
3 changes: 3 additions & 0 deletions Src/LinearSolvers/MLMG/AMReX_MLEBABecLap.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ public:
Vector<Vector<MultiFab> > m_a_coeffs;
Vector<Vector<Array<MultiFab,AMREX_SPACEDIM> > > m_b_coeffs;

bool m_scalars_set = false;
bool m_acoef_set = false;

protected:

int m_ncomp = 1;
Expand Down
6 changes: 6 additions & 0 deletions Src/LinearSolvers/MLMG/AMReX_MLEBABecLap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,21 +116,25 @@ MLEBABecLap::setScalars (Real a, Real b)
{
m_a_coeffs[amrlev][0].setVal(0.0);
}
m_acoef_set = true;
}
m_scalars_set = true;
}

void
MLEBABecLap::setACoeffs (int amrlev, const MultiFab& alpha)
{
MultiFab::Copy(m_a_coeffs[amrlev][0], alpha, 0, 0, 1, 0);
m_needs_update = true;
m_acoef_set = true;
}

void
MLEBABecLap::setACoeffs (int amrlev, Real alpha)
{
m_a_coeffs[amrlev][0].setVal(alpha);
m_needs_update = true;
m_acoef_set = true;
}

void
Expand Down Expand Up @@ -1185,6 +1189,8 @@ MLEBABecLap::update ()
{
if (MLCellABecLap::needsUpdate()) { MLCellABecLap::update(); }

applyRobinBCTermsCoeffs();

averageDownCoeffs();

m_is_singular.clear();
Expand Down
Loading