Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC: SoA Name Helpers #4300

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 18, 2025

Summary

Add name to index getters and query (has) functions to SoA names. Ported over from ImpactX.

Additional background

ECP-WarpX/impactx#805

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l ax3l requested a review from atmyers January 18, 2025 01:00
@ax3l ax3l requested a review from WeiqunZhang January 18, 2025 18:33
@ax3l ax3l force-pushed the topic-add-name-helpers branch from 5486f1d to 306be86 Compare January 21, 2025 20:05
@ax3l
Copy link
Member Author

ax3l commented Jan 21, 2025

@atmyers rebased and ready for review :)

@ax3l
Copy link
Member Author

ax3l commented Jan 21, 2025

@WeiqunZhang I think the CI codespell issues are unrelated to this PR.

Add name to index getters and query (has) functions to SoA
names. Ported over from ImpactX.
@ax3l ax3l force-pushed the topic-add-name-helpers branch from 306be86 to 665434b Compare January 21, 2025 20:10
@WeiqunZhang
Copy link
Member

There is probably a new version of codespell. I will remove the check from required list. Then will try to fix it.

@ax3l
Copy link
Member Author

ax3l commented Jan 21, 2025

Thanks! Yes looked like it just found new locations.

PR ready for review :)

@ax3l ax3l merged commit d4d9214 into AMReX-Codes:development Jan 21, 2025
73 of 74 checks passed
@ax3l ax3l deleted the topic-add-name-helpers branch January 21, 2025 23:37
ax3l added a commit to AMReX-Codes/pyamrex that referenced this pull request Jan 23, 2025
Update to latest commit in `development`.
Pull in fixes
- [x] AMReX-Codes/amrex#4298
- [x] AMReX-Codes/amrex#4299
- [x] AMReX-Codes/amrex#4302
- [x] AMReX-Codes/amrex#4300

for #382.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants