Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove ICC/ICPC (Compiler Classic) #4303

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 18, 2025

Summary

Fails now in CI. For a while it remarks:

icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.

Additional background

#4299 (comment)

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

Fails now in CI. For a while it remarks:
> icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
@ax3l ax3l added the test label Jan 18, 2025
@ax3l ax3l requested review from atmyers and WeiqunZhang January 18, 2025 01:40
@ax3l ax3l added the cleaning label Jan 18, 2025
@ax3l ax3l changed the title CI: Remove ICC CI: Remove ICC/ICPC (Compiler Classic) Jan 18, 2025
@WeiqunZhang
Copy link
Member

It seems that icc is incompatible with Ubuntu 24.04, which is now github runner's ubuntu-latest.

@WeiqunZhang WeiqunZhang enabled auto-merge (squash) January 18, 2025 02:48
@WeiqunZhang WeiqunZhang merged commit 90373e7 into AMReX-Codes:development Jan 18, 2025
73 of 74 checks passed
@ax3l ax3l deleted the ci-remove-icc branch January 18, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants