Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiFab: Static to Member Math Methods #301

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Apr 25, 2024

Replace static member functions that with regular member functions that take store the result/destination in self. (Assume dst is self.)

  • FabArray<FArrayBox>
  • MultiFab

Close #296

@ax3l ax3l added help wanted Extra attention is needed API: breaking Breaking changes labels Apr 25, 2024
@ax3l ax3l requested a review from RemiLehe April 25, 2024 02:55
@ax3l ax3l changed the title [WIP] MultiFab: Static to Member Math Methods MultiFab: Static to Member Math Methods Jan 28, 2025
@ax3l ax3l removed the help wanted Extra attention is needed label Jan 28, 2025
src/Base/MultiFab.cpp Outdated Show resolved Hide resolved
@ax3l ax3l requested a review from WeiqunZhang January 28, 2025 23:11
Replace `static` member functions that with regular member functions
that take store the result/destination in `self`.
@ax3l
Copy link
Member Author

ax3l commented Jan 29, 2025

I will go ahead and merge this, because I have a massive restructuring PR to add support for iMultiFab that depends on these changes: #410

@ax3l ax3l merged commit 1f91a4d into AMReX-Codes:development Jan 29, 2025
17 of 18 checks passed
@ax3l ax3l deleted the mf-rm-static branch January 29, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: breaking Breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiFab: Only Member Functions
2 participants