-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some improvements and testing for the EB covered state #704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! thank you, Bruce.
The end of timestep NaN check works at least on AMD and Nvidia GPUs (Frontier and Eagle). On GPU, the abort for invalid stencils only works in debug mode or with USE_ASSERTION=TRUE. Did not notice a change in performance. |
Tests/CMakeLists.txt
Outdated
@@ -55,11 +55,11 @@ macro(setup_test) | |||
file(COPY ${CURRENT_TEST_SOURCE_DIR}/${TEST_NAME}.inp DESTINATION "${CURRENT_TEST_BINARY_DIR}/") | |||
file(COPY ${TEST_FILES} DESTINATION "${CURRENT_TEST_BINARY_DIR}/") | |||
# Set some default runtime options for all tests | |||
set(RUNTIME_OPTIONS "amr.plot_file=plt amr.checkpoint_files_output=0 amr.plot_files_output=1 amrex.the_arena_is_managed=0") | |||
set(RUNTIME_OPTIONS_AlL "amr.plot_file=plt amr.checkpoint_files_output=0 amr.plot_files_output=1 amrex.the_arena_is_managed=0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo here.
@@ -113,6 +113,14 @@ function(add_test_rf TEST_NAME TEST_EXE_DIR) | |||
set_tests_properties(${TEST_NAME} PROPERTIES WILL_FAIL TRUE) | |||
endfunction(add_test_rf) | |||
|
|||
# Regression tests no FPE trapping ever |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test won't have these options amr.plot_file=plt amr.checkpoint_files_output=0 amr.plot_files_output=1 amrex.the_arena_is_managed=0
, which I think we would want to enforce.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I'm confused. It just has the same options as the other tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could leave the RUNTIME_OPTIONS
as is and just add amrex.signal_handling=0
to this test category.
This closes #703, with the goal of ensuring that covered cells never affect fluid cell values:
ebd.boundary_grad_stencil_type = 0
)zero_in_body
has been deleted because it was not used anywhereTests/CMakeLists.txt
because this test can't run with AMReX FPE trapping.