Implement the state prescription at EB for the Riemann solver #774

marchdf · 2024-03-28T16:47:35Z

TODO:

document this and warn users about it (it's beta, only right for hydro fluxes)
add an abort if using godunov
add a user defined flag "do_problem_eb_fill" that gets passed to pc_compute_hyp_mol_flux_eb
move ebfill into the problem specific function stuff
test on eb-inflow case

Source/MOL.cpp

Exec/RegTests/EB-InflowBC/prob.H

Exec/RegTests/EB-InflowBC/prob.cpp

marchdf requested a review from baperry2 March 28, 2024 16:47

marchdf force-pushed the eb-inflow branch 9 times, most recently from 334f340 to 298135e Compare March 28, 2024 21:40

baperry2 reviewed Mar 28, 2024

View reviewed changes

Source/MOL.cpp Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems Mar 28, 2024

View reviewed changes

marchdf added 4 commits April 5, 2024 12:34

Implement the state prescription at EB for the Riemann solver

371927b

fix warn

dce342c

more warns

5c0f761

rename and add user param

b9bf45c

marchdf force-pushed the eb-inflow branch from 43828bd to b9bf45c Compare April 5, 2024 18:49

Add abort for godunov

1376e56

marchdf marked this pull request as ready for review April 5, 2024 18:55

marchdf requested a review from baperry2 April 5, 2024 18:55

tweak doc

ca77a7b

marchdf enabled auto-merge (squash) April 9, 2024 17:06

Merge branch 'development' into eb-inflow

667d26f

baperry2 approved these changes Apr 10, 2024

View reviewed changes

marchdf merged commit e6be861 into development Apr 10, 2024
14 checks passed

marchdf deleted the eb-inflow branch April 10, 2024 20:54

Provide feedback