Fix bug in LES coefficient calculation. #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See Formula 17 on page 365 in Martín, M. Pino, U. Piomelli, and G. V. Candler. "Subgrid-Scale Models for Compressible Large-Eddy Simulations." Theoretical and Computational Fluid Dynamics 13, no. 5 (2000): 361–76. https://link.springer.com/article/10.1007/PL00020896 Thanks to @bronise777 for finding this.
baperry2
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Digging up the old fortran version, it looks like we used to have - instead of *, so this was probably a transcription error when porting to C++
PeleC/Source/Src_3d/lesterm_3d.f90
Line 703 in 8432c20
|
Wow nice sleuthing!! I wonder how this happened... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Formula 17 on page 365 in Martín, M. Pino, U. Piomelli, and G. V. Candler. "Subgrid-Scale Models for Compressible Large-Eddy Simulations." Theoretical and Computational Fluid Dynamics 13, no. 5 (2000):
361–76. https://link.springer.com/article/10.1007/PL00020896
Thanks to @bronise777 for finding this. Discussed in #845