Fix warns (#248)

* bugprone-macro-parentheses * Turn on the ci * modernize-make-unique * minor thing * minor * header stuff * dont check amrex-hydro * Revert "modernize-make-unique" This reverts commit 1f9bddf. * Fix quotes. * Fix readability-qualified-auto. * Fix readability-braces-around-statements. * Fix modernize-use-override. * Fix readability-redundant-string-init. --------- Co-authored-by: Jon Rood <[email protected]>
AMReX-Combustion · Sep 18, 2023 · 15fc3be · 15fc3be
1 parent 8f61bc6
commit 15fc3be
Show file tree

Hide file tree

Showing 118 changed files with 442 additions and 372 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -570,7 +570,7 @@ jobs:
           #set -eu -o pipefail
           cmake --build . --parallel ${{env.NPROCS}} 2>&1 | tee -a clang-tidy-full-report.txt
           egrep "warning:|error:" clang-tidy-full-report.txt \
-            | egrep -v "Submodules/amrex|Submodules/sundials" \
+            | egrep -v "Submodules/amrex|Submodules/sundials|Submodules/AMReX-Hydro" \
             | egrep -v "ld: warning:" | sort | uniq \
             | awk 'BEGIN{i=0}{print $0}{i++}END{print "Warnings: "i}' > clang-tidy-warnings.txt
       - name: Full report
@@ -582,7 +582,7 @@ jobs:
           echo "::add-matcher::.github/problem-matchers/gcc.json"
           cat clang-tidy-warnings.txt
           export return=$(tail -n 1 clang-tidy-warnings.txt | awk '{print $2}')
-          #exit ${return}
+          exit ${return}
   Lint-codeql:
     needs: Formatting
     runs-on: ubuntu-latest

diff --git a/Exec/Cases/ChallengeProblem/EBUserDefined.H b/Exec/Cases/ChallengeProblem/EBUserDefined.H
@@ -1,5 +1,5 @@
-#ifndef _EBUSERDEFINED_H_
-#define _EBUSERDEFINED_H_
+#ifndef _EBUSERDEFINED_H
+#define _EBUSERDEFINED_H
 
 using namespace amrex;
 

diff --git a/Exec/Cases/ChallengeProblem/pelelm_prob.H b/Exec/Cases/ChallengeProblem/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/Cases/ChallengeProblem/pelelm_prob_parm.H b/Exec/Cases/ChallengeProblem/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 #include <AMReX_GpuMemory.H>

diff --git a/Exec/Cases/CounterFlow/pelelm_prob.H b/Exec/Cases/CounterFlow/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/Cases/CounterFlow/pelelm_prob_parm.H b/Exec/Cases/CounterFlow/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 

diff --git a/Exec/Cases/CounterFlowSpray/pelelm_prob.H b/Exec/Cases/CounterFlowSpray/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/Cases/CounterFlowSpray/pelelm_prob_parm.H b/Exec/Cases/CounterFlowSpray/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 

diff --git a/Exec/Cases/DiffBunsen2D/pelelm_prob.H b/Exec/Cases/DiffBunsen2D/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/Cases/DiffBunsen2D/pelelm_prob_parm.H b/Exec/Cases/DiffBunsen2D/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 

diff --git a/Exec/Cases/JetInCrossflow/pelelm_prob.H b/Exec/Cases/JetInCrossflow/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_FArrayBox.H>
 #include <AMReX_Geometry.H>

diff --git a/Exec/Cases/JetInCrossflow/pelelm_prob_parm.H b/Exec/Cases/JetInCrossflow/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 #include <AMReX_GpuMemory.H>

diff --git a/Exec/Cases/NormalJet_OpenDomain/pelelm_prob.H b/Exec/Cases/NormalJet_OpenDomain/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/Cases/NormalJet_OpenDomain/pelelm_prob_parm.H b/Exec/Cases/NormalJet_OpenDomain/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 #include <AMReX_GpuMemory.H>

diff --git a/Exec/Cases/PremBunsen2D/pelelm_prob.H b/Exec/Cases/PremBunsen2D/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/Cases/PremBunsen2D/pelelm_prob_parm.H b/Exec/Cases/PremBunsen2D/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 

diff --git a/Exec/Cases/PremBunsen3D/pelelm_prob.H b/Exec/Cases/PremBunsen3D/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/Cases/PremBunsen3D/pelelm_prob_parm.H b/Exec/Cases/PremBunsen3D/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 

diff --git a/Exec/Cases/SwirlFlowWallInteractions/pelelm_prob.H b/Exec/Cases/SwirlFlowWallInteractions/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/Cases/SwirlFlowWallInteractions/pelelm_prob_parm.H b/Exec/Cases/SwirlFlowWallInteractions/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 #include <AMReX_GpuMemory.H>

diff --git a/Exec/Cases/TripleFlame/pelelm_prob.H b/Exec/Cases/TripleFlame/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/Cases/TripleFlame/pelelm_prob_parm.H b/Exec/Cases/TripleFlame/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 #include <AMReX_GpuMemory.H>

diff --git a/Exec/Efield/FlameSheetIons/pelelm_prob.H b/Exec/Efield/FlameSheetIons/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/Efield/FlameSheetIons/pelelm_prob_parm.H b/Exec/Efield/FlameSheetIons/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 

diff --git a/Exec/Efield/IonizedAirWave/pelelm_prob.H b/Exec/Efield/IonizedAirWave/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/Efield/IonizedAirWave/pelelm_prob_parm.H b/Exec/Efield/IonizedAirWave/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 

diff --git a/Exec/Efield/PremBunsen3DKuhl/pelelm_prob.H b/Exec/Efield/PremBunsen3DKuhl/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/Efield/PremBunsen3DKuhl/pelelm_prob_parm.H b/Exec/Efield/PremBunsen3DKuhl/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 

diff --git a/Exec/RegTests/EB_BackwardStepFlame/EBUserDefined.H b/Exec/RegTests/EB_BackwardStepFlame/EBUserDefined.H
@@ -1,5 +1,5 @@
-#ifndef _EBUSERDEFINED_H_
-#define _EBUSERDEFINED_H_
+#ifndef EBUSERDEFINED_H
+#define EBUSERDEFINED_H
 
 using namespace amrex;
 

diff --git a/Exec/RegTests/EB_BackwardStepFlame/pelelm_prob.H b/Exec/RegTests/EB_BackwardStepFlame/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/RegTests/EB_BackwardStepFlame/pelelm_prob_parm.H b/Exec/RegTests/EB_BackwardStepFlame/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 

diff --git a/Exec/RegTests/EB_EnclosedFlame/pelelm_prob.H b/Exec/RegTests/EB_EnclosedFlame/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/RegTests/EB_EnclosedFlame/pelelm_prob_parm.H b/Exec/RegTests/EB_EnclosedFlame/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 #include <AMReX_GpuMemory.H>

diff --git a/Exec/RegTests/EB_EnclosedVortex/pelelm_prob.H b/Exec/RegTests/EB_EnclosedVortex/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/RegTests/EB_EnclosedVortex/pelelm_prob_parm.H b/Exec/RegTests/EB_EnclosedVortex/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 #include <AMReX_GpuMemory.H>

diff --git a/Exec/RegTests/EB_FlowPastCylinder/EBUserDefined.H b/Exec/RegTests/EB_FlowPastCylinder/EBUserDefined.H
@@ -1,5 +1,5 @@
-#ifndef _EBUSERDEFINED_H_
-#define _EBUSERDEFINED_H_
+#ifndef EBUSERDEFINED_H
+#define EBUSERDEFINED_H
 
 using namespace amrex;
 

diff --git a/Exec/RegTests/EB_FlowPastCylinder/pelelm_prob.H b/Exec/RegTests/EB_FlowPastCylinder/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/RegTests/EB_FlowPastCylinder/pelelm_prob_parm.H b/Exec/RegTests/EB_FlowPastCylinder/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 #include <AMReX_GpuMemory.H>

diff --git a/Exec/RegTests/EB_PipeFlow/EBUserDefined.H b/Exec/RegTests/EB_PipeFlow/EBUserDefined.H
@@ -1,5 +1,5 @@
-#ifndef _EBUSERDEFINED_H_
-#define _EBUSERDEFINED_H_
+#ifndef EBUSERDEFINED_H
+#define EBUSERDEFINED_H
 
 using namespace amrex;
 

diff --git a/Exec/RegTests/EB_PipeFlow/pelelm_prob.H b/Exec/RegTests/EB_PipeFlow/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/RegTests/EB_PipeFlow/pelelm_prob_parm.H b/Exec/RegTests/EB_PipeFlow/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 #include <AMReX_GpuMemory.H>

diff --git a/Exec/RegTests/EnclosedFlame/pelelm_prob.H b/Exec/RegTests/EnclosedFlame/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/RegTests/EnclosedFlame/pelelm_prob_parm.H b/Exec/RegTests/EnclosedFlame/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 #include <AMReX_GpuMemory.H>

diff --git a/Exec/RegTests/EnclosedInjection/pelelm_prob.H b/Exec/RegTests/EnclosedInjection/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/RegTests/EnclosedInjection/pelelm_prob_parm.H b/Exec/RegTests/EnclosedInjection/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 

diff --git a/Exec/RegTests/FlameSheet/pelelm_prob.H b/Exec/RegTests/FlameSheet/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>

diff --git a/Exec/RegTests/FlameSheet/pelelm_prob_parm.H b/Exec/RegTests/FlameSheet/pelelm_prob_parm.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_PARM_H_
-#define PELELM_PROB_PARM_H_
+#ifndef PELELM_PROB_PARM_H
+#define PELELM_PROB_PARM_H
 
 #include <AMReX_REAL.H>
 #include <AMReX_GpuMemory.H>

diff --git a/Exec/RegTests/HITDecay/pelelm_prob.H b/Exec/RegTests/HITDecay/pelelm_prob.H
@@ -1,5 +1,5 @@
-#ifndef PELELM_PROB_H_
-#define PELELM_PROB_H_
+#ifndef PELELM_PROB_H
+#define PELELM_PROB_H
 
 #include <AMReX_Geometry.H>
 #include <AMReX_FArrayBox.H>