-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move PeleRad source files to PelePhysics #459
Conversation
when we merge can we add "Co-authored-by: Wenjun Ge [email protected]" to the commit message? That way we know who to bug for certain files ;) |
@wjge pointed out that he set up some unit tests for radiation. Can we port those over as well? |
These six tests are needed: tstPOneMulti.cpp The boost test stuff can be replaced by what Pele is using. |
Yes. Currently I need to debug why moving these files causes SootRadTest to fail. |
When I initially added that test to PeleLMeX, I had some mysterious failures that ended up being that it wasnt reading the kp data files correctly, so I'd recommend double checking that |
Tasks: