Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PeleRad source files to PelePhysics #459

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Conversation

jrood-nrel
Copy link
Contributor

@jrood-nrel jrood-nrel commented Dec 13, 2023

Tasks:

  • Remove std::filesystem
  • Add existing tests

@marchdf
Copy link
Contributor

marchdf commented Dec 14, 2023

when we merge can we add "Co-authored-by: Wenjun Ge [email protected]" to the commit message? That way we know who to bug for certain files ;)

@baperry2
Copy link
Contributor

@wjge pointed out that he set up some unit tests for radiation. Can we port those over as well?

@wjge
Copy link
Member

wjge commented Dec 14, 2023

These six tests are needed:

tstPOneMulti.cpp
tstPOneMultiAF.cpp
tstPOneMultiEB.cpp
tstPOneSingle.cpp
tstPOneSingleAF.cpp
tstPOneSingleEB.cpp

The boost test stuff can be replaced by what Pele is using.

@jrood-nrel
Copy link
Contributor Author

Yes. Currently I need to debug why moving these files causes SootRadTest to fail.

@baperry2
Copy link
Contributor

When I initially added that test to PeleLMeX, I had some mysterious failures that ended up being that it wasnt reading the kp data files correctly, so I'd recommend double checking that

@jrood-nrel jrood-nrel marked this pull request as ready for review December 18, 2023 20:21
@jrood-nrel jrood-nrel enabled auto-merge (squash) December 18, 2023 20:46
@jrood-nrel jrood-nrel merged commit 8e091fa into development Dec 18, 2023
8 checks passed
@jrood-nrel jrood-nrel deleted the jrood/pelerad branch December 18, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants