Support Manifold EoS in RK64 Reactor #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
baperry2
commented
Jul 19, 2024
•
baperry2
commented
- Pass eosparm through the ReactorRK64 call stack so it can be used as needed
- Also fixes a bug where the limit to avoid overstepping the integration time for RK64 was not being applied properly for the 1D version.
- add a test case for ignition delay with tabulated chemistry
baperry2
force-pushed
the
reactor-manifold
branch
2 times, most recently
from
2a6ea71 to
ac82315
Compare
baperry2
force-pushed
the
reactor-manifold
branch
from
ac82315 to
bb1c21e
Compare
marchdf
approved these changes
Sep 19, 2024
| eosparm) | ||
| { | ||
| auto eos = pele::physics::PhysicsType::eos(eosparm); | ||
| if (eos.identifier() == "Manifold") { |
There was a problem hiding this comment.
could replace all this with AMREX_ALWAYS_ASSERT_WITH_MESSAGE
|
In this PR, can you fix a small typo? https://github.com/AMReX-Combustion/PelePhysics/blob/development/README.md?plain=1#L18 should be Radiative |
malihass
requested changes
Sep 22, 2024
malihass
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.