Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vof #111

Open
wants to merge 52 commits into
base: development
Choose a base branch
from
Open

Vof #111

wants to merge 52 commits into from

Conversation

IFDL-WSU
Copy link

No description provided.

@ruohai0925
Copy link

ruohai0925 commented Jun 22, 2024

Hi, Dr Tan Hua,

I am Yadong. We met earlier in the Gerris-basilisk meeting at Princeton University. I am wondering if there will be a paper about this PR to describe the VOF algorithm later?

Copy link
Author

@IFDL-WSU IFDL-WSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating vof class

@IFDL-WSU
Copy link
Author

Hi, Dr Tan Hua,

I am Yadong. We met earlier in the Gerris-basilisk meeting at Princeton University. I am wondering if there will be a paper about this PR to describe the VOF algorithm later?

Hi Yadong, The vof method I'm planning to implement in AMReX/incflo is going to be same as the method in Gerris/Basilisk. Popinet's 2009 JCP paper details the algorithm. I hope to get most work done by the end of this year. Stay tune. Best, Hua

@ruohai0925
Copy link

Hi, Dr Tan Hua,
I am Yadong. We met earlier in the Gerris-basilisk meeting at Princeton University. I am wondering if there will be a paper about this PR to describe the VOF algorithm later?

Hi Yadong, The vof method I'm planning to implement in AMReX/incflo is going to be same as the method in Gerris/Basilisk. Popinet's 2009 JCP paper details the algorithm. I hope to get most work done by the end of this year. Stay tune. Best, Hua

Got it! That will be really nice. During my Ph.D., I also carefully read Popinet's 2003 and 2009 JCP paper. Yet our group used the CLSVOF, that is why I did not choose the direction to implement the pure VOF method at that time.

The incflo uses the nonsucycling method and the IAMR uses the subcycling method. One thought is if you can make the VOF a standalone feature while combining it with incflow advance functions, maybe I can also learn to combine this feature with IAMR later when it is ready. I am very interested in investigating how the algorithms work in the AMR framework.

@IFDL-WSU
Copy link
Author

Hi, Dr Tan Hua,
I am Yadong. We met earlier in the Gerris-basilisk meeting at Princeton University. I am wondering if there will be a paper about this PR to describe the VOF algorithm later?

Hi Yadong, The vof method I'm planning to implement in AMReX/incflo is going to be same as the method in Gerris/Basilisk. Popinet's 2009 JCP paper details the algorithm. I hope to get most work done by the end of this year. Stay tune. Best, Hua

Got it! That will be really nice. During my Ph.D., I also carefully read Popinet's 2003 and 2009 JCP paper. Yet our group used the CLSVOF, that is why I did not choose the direction to implement the pure VOF method at that time.

The incflo uses the nonsucycling method and the IAMR uses the subcycling method. One thought is if you can make the VOF a standalone feature while combining it with incflow advance functions, maybe I can also learn to combine this feature with IAMR later when it is ready. I am very interested in investigating how the algorithms work in the AMR framework.

Thank you for your advice, Yadong! Yes, I desire to develop the VOF capability as an add-on class, so the developers of other AMReX platform based software can easily add it to their codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants