Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

put in basic data structures / operations for cc-projection as altern… #134

Merged
merged 9 commits into from
Sep 25, 2024
Merged

put in basic data structures / operations for cc-projection as altern… #134

merged 9 commits into from
Sep 25, 2024

Conversation

asalmgren
Copy link
Contributor

…ative to nodal projection

isriva
isriva approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@isriva isriva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR now looks good to me. Satisfactory results for several test runs including with EB geometries. Did not try multilevel simulations yet, but we can perhaps fix later in case any issues arise with that.

@asalmgren asalmgren merged commit 8796a02 into AMReX-Fluids:development Sep 25, 2024
11 of 12 checks passed
@asalmgren asalmgren deleted the new_cc_proj branch September 25, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isriva isriva isriva approved these changes

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

@ajnonaka ajnonaka Awaiting requested review from ajnonaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asalmgren @WeiqunZhang @isriva