Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix for initial dt. We need to reset dt at the end of #83

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

cgilet
Copy link
Collaborator

@cgilet cgilet commented Oct 19, 2023

InitialIterations in order to get the specifed dt. Otherwise, we can end up with dt = initial_dt*change_max.

InitialIterations in order to get the specifed dt. Otherwise, we
can end up with dt = initial_dt*change_max.
@cgilet cgilet requested a review from asalmgren October 19, 2023 16:33
Copy link
Contributor

@ajnonaka ajnonaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. A separate question would be, do you want the dt to increase at all during the initial iterations.

@cgilet
Copy link
Collaborator Author

cgilet commented Oct 19, 2023

@ajnonaka The dt is fixed during the Initial iters and does not increase, because it calls apply_predictor, and apply_predicitor does not compute dt (that's done in advance). It's just incflo::InitialIterations() calls ComputeDt at the beginning, and then incflo::advance() also calls it at the start. So this one reset at the end of InitialIterations should be enough, I think.

@cgilet cgilet merged commit 58de1d9 into development Nov 2, 2023
30 checks passed
@cgilet cgilet deleted the fix_initial_dt branch November 2, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants