Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure initial_shrink still gets applied. together with pr83, this #84

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

cgilet
Copy link
Collaborator

@cgilet cgilet commented Nov 3, 2023

ensures the initial timestep is computed as expected. This will require redoing some regression tests due to the change in the initial dt.

ensures the initial timestep is computed as expected.
@cgilet
Copy link
Collaborator Author

cgilet commented Nov 3, 2023

@ajnonaka This catches an oversight in pr83.

@WeiqunZhang WeiqunZhang requested a review from ajnonaka November 6, 2023 17:48
@ajnonaka ajnonaka merged commit 7a525e0 into development Nov 6, 2023
30 checks passed
@cgilet cgilet deleted the fix_pr83 branch June 13, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants