Consolidate code #88
Merged
Consolidate code #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cgilet
commented
Feb 21, 2024
cgilet
commented
- Update make_eb_box() to use amrex::BoxIF. This allows specifying internal or external flow.
- Remove incflo::set_velocity_bc functions in favor of using PhysBCFunct, which is needed to set the inflow bcs during FillPatch. Now we only need one function to set the inflow bc.
- Rename file to better reflect contents which includes setting density and tracer EB bcs. Renamed: incflo_set_velocity_bcs.cpp -> incflo_set_bcs.cpp
renamed: incflo_set_velocity_bcs.cpp -> incflo_set_bcs.cpp
internal or external flow.
PhysBCFunct, which we use to set the inflow bcs during FillPatch.
The rest should stay zero.
|
@asalmgren this passes the regression tests |
asalmgren
approved these changes
Mar 15, 2024
siddanib
pushed a commit
to siddanib/incflo
that referenced
this pull request
Apr 2, 2024
* Update make_eb_box() to use amrex::BoxIF. This allows specifying internal or external flow. * Remove incflo::set_velocity_bc functions in favor of using PhysBCFunct, which is needed to set the inflow bcs during FillPatch. Now we only need one function to set the inflow bc. * Rename file to better reflect contents which includes setting density and tracer EB bcs. Renamed: incflo_set_velocity_bcs.cpp -> incflo_set_bcs.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.