Remove duplicate keys from schema defintions #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks @Mantls. Did you run an automated check to identify all of these? We should integrate this check into our linting. |
|
Sort of, i spotted this during automatic code generation. json-refs was complaining about the duplicate keys. |
|
The nmos-lint-scripts use npm jsonlint package, and this doesn't report on duplicate keys: zaach/jsonlint#13 Looks like a well-maintained fork of that package has an option to check for duplicate keys: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be some copy/paste error.
JSON keys 'should' be unique and a lot of JSON parsing software throws errors on duplicate keys or shows otherwise unpredictable behavior.