-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/grow - Merged master into #174 #330
base: master
Are you sure you want to change the base?
Feature/grow - Merged master into #174 #330
Conversation
Thank you, it has been imported. |
Thank you @raghavakumar8 and @SteveQUT I have successfully used this PR. It works and works fast. About the API, for my use case, I receive a new |
size(0) = static_cast<int>(round(length(0) / resolution_)); | ||
size(1) = static_cast<int>(round(length(1) / resolution_)); | ||
conservativeResize(size, direction, value); | ||
length_ = length; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to replace this line by this one to avoid alignment issues:
length_ = length; | |
length_ = (size_.cast<double>() * resolution_).matrix(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taken from here:
grid_map/grid_map_core/src/GridMap.cpp
Line 57 in c23dcde
length_ = (size_.cast<double>() * resolution_).matrix(); |
Would it make sense to add the complementary I personally have a use case where I want to regularly adjust the size of the map to contain some minimum amount of information. For example, keeping the smallest map possible that contains some minimum amount of obstacles. Here, it would be useful to grow the map when it is too sparse and shrink it if it is too dense. |
Merged in current master to Grow feature.
Updates #174