-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor edits in Section 8 Profiles #286
Minor edits in Section 8 Profiles #286
Conversation
@@ -751,7 +751,7 @@ The profiles defined in this section are for enabling interoperability between [ | |||
|
|||
<assert>The <code>[=FileTypeBox=]</code> should declare at least one profile that enables decoding of the [=primary image item=].</assert> It is not an error for the encoder to include an auxiliary image that is not allowed by the specified profile(s). | |||
|
|||
<assert>If <code>'[=avis=]'</code> is declared in the <code>[=FileTypeBox=]</code> and a profile is declared in the <code>[=FileTypeBox=]</code>, the profile shall also enable decoding of at least one image sequence track.</assert> <assert>The profile should allow decoding of any associated auxiliary image sequence tracks, unless it is acceptable to decode the image sequence without its auxiliary image sequence tracks.</assert> | |||
<assert>If <code>'[=avis=]'</code> is declared in the <code>[=FileTypeBox=]</code> and a profile is declared in the <code>[=FileTypeBox=]</code>, the profile shall also enable decoding of at least one image sequence track.</assert> <assert>The profile should allow decoding of any associated auxiliary image sequence tracks, unless it is acceptable to decode the image sequence track without its auxiliary image sequence tracks.</assert> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the word "track" after "image sequence" because the rest of this paragraph uses the term "image sequence track" consistently.
@@ -777,9 +777,9 @@ The following shared conditions and requirements from [[!MIAF]] should apply: | |||
The following additional constraints apply to all [=AV1 Image Items=] and all [=AV1 Image Sequences=]: | |||
- <assert>The AV1 profile shall be the Main Profile and the level shall be 5.1 or lower.</assert> | |||
|
|||
NOTE: AV1 tiers are not constrained because timing is optional in image sequences and are not relevant in image items or collections. | |||
NOTE: AV1 tiers are not constrained because timing is optional in image sequences and is not relevant in image items or collections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The subject is "timing", so the verb should be the singular "is".
|
||
NOTE: Level 5.1 is chosen for the Baseline profile to ensure that no single coded image exceeds 4k resolution, as some decoder may not be able to handle larger images. More precisely, following [[!AV1]] level definitions, coded image items compliant to the [=AVIF Baseline profile=] may not have a number of pixels greater than 8912896, a width greater than 8192 or a height greater than 4352. It is still possible to use the Baseline profile to create larger images using a [=grid derived image item=]. | ||
NOTE: Level 5.1 is chosen for the Baseline profile to ensure that no single coded image exceeds 4k resolution, as some decoders may not be able to handle larger images. More precisely, following [[!AV1]] level definitions, coded image items compliant to the [=AVIF Baseline profile=] may not have a number of pixels greater than 8912896, a width greater than 8192 or a height greater than 4352. It is still possible to use the Baseline profile to create larger images using a [=grid derived image item=]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed "some decoder" to "some decoders" (plural) because we are not referring to a certain decoder here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'decoder' to 'decoders' change looks good to me.
I think '4k' should be '8k' no? Since in the next section it describes a 8k resolution. Level 3 is ~4K (4352x2448).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also wondered about that. It turns out that for each level, the maximum number of pixels is more restrictive than the maximum width or height. So one possible explanation I came up with for "no single coded image exceeds 4k resolution" is that the maximum number of pixels 8912896 (= 4352 * 2048) is close to 4k resolution.
But even with this explanation, 8912896 > 4126 x 2160, which exceeds 4k resolution. So the statement that at level 5.1 "no single coded image exceeds 4k resolution" is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... How about something like this?
Level 5.1 is chosen for the Baseline profile as some decoders may not be able to handle coded images larger than approximately 4k resolution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion! We can write a separate pull request to fix that.
By the way, I checked the levels around level 5.1 more closely. I found that no level supports exactly 4k resolution, but levels 5.0 - 5.3 are the closest to 4k resolution. Among these levels, it's not clear why level 5.1 was chosen. It may have to do with the frame rate limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed #290 for this issue.
|
||
NOTE: Level 5.1 is chosen for the Baseline profile to ensure that no single coded image exceeds 4k resolution, as some decoder may not be able to handle larger images. More precisely, following [[!AV1]] level definitions, coded image items compliant to the [=AVIF Baseline profile=] may not have a number of pixels greater than 8912896, a width greater than 8192 or a height greater than 4352. It is still possible to use the Baseline profile to create larger images using a [=grid derived image item=]. | ||
NOTE: Level 5.1 is chosen for the Baseline profile to ensure that no single coded image exceeds 4k resolution, as some decoders may not be able to handle larger images. More precisely, following [[!AV1]] level definitions, coded image items compliant to the [=AVIF Baseline profile=] may not have a number of pixels greater than 8912896, a width greater than 8192 or a height greater than 4352. It is still possible to use the Baseline profile to create larger images using a [=grid derived image item=]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... How about something like this?
Level 5.1 is chosen for the Baseline profile as some decoders may not be able to handle coded images larger than approximately 4k resolution.
Preview | Diff