Update comments. Note recon_gain_is_present_flag. Unify "ambisonics…

… order" styling. - Annotate the `recon_gain_is_present_flag` in some arbitrary OBUs. - Prefer using "zeroth-order" instead of "zero" when discussing ambisonics (analog of "first-order", "second-order", ...). PiperOrigin-RevId: 662257801
AOMediaCodec · Aug 12, 2024 · b180803 · b180803
1 parent ca93848
commit b180803
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/iamf/cli/testdata/test_000100.textproto b/iamf/cli/testdata/test_000100.textproto
@@ -13,7 +13,7 @@
 
 test_vector_metadata {
   human_readable_description:
-    "A zero-order ambisonics IAMF stream encoded using "
+    "A zeroth-order ambisonics IAMF stream encoded using "
     "`ambisonics_mode` = `MONO`."
   file_name_prefix: "test_000100"
   is_valid: true

diff --git a/iamf/cli/testdata/test_000104.textproto b/iamf/cli/testdata/test_000104.textproto
@@ -13,7 +13,7 @@
 
 test_vector_metadata {
   human_readable_description:
-    "A zero-order ambisonics IAMF stream encoded using "
+    "A zeroth-order ambisonics IAMF stream encoded using "
     "`ambisonics_mode` = `PROJECTION`."
   file_name_prefix: "test_000104"
   is_valid: true

diff --git a/iamf/cli/testdata/test_000108.textproto b/iamf/cli/testdata/test_000108.textproto
@@ -13,7 +13,7 @@
 
 test_vector_metadata {
   human_readable_description:
-    "A zero-order ambisonics IAMF stream encoded using Opus and "
+    "A zeroth-order ambisonics IAMF stream encoded using Opus and "
     "`ambisonics_mode` = `MONO`."
   file_name_prefix: "test_000108"
   is_valid: true

diff --git a/iamf/cli/testdata/test_000112.textproto b/iamf/cli/testdata/test_000112.textproto
@@ -13,7 +13,7 @@
 
 test_vector_metadata {
   human_readable_description:
-    "A zero-order ambisonics IAMF stream encoded using Opus and "
+    "A zeroth-order ambisonics IAMF stream encoded using Opus and "
     "`ambisonics_mode` = `PROJECTION`."
   file_name_prefix: "test_000112"
   is_valid: true

diff --git a/iamf/cli/testdata/test_000119.textproto b/iamf/cli/testdata/test_000119.textproto
@@ -175,7 +175,7 @@ arbitrary_obu_metadata: [
       "\x01"  # substream_id.
       "\x00"  # num_parameters.
       "\x20"  # num_layers (3), reserved (5)
-      "\x10"  # loudspeaker_layout (4), output_gain_is_present_flag (1), reserved (2).
+      "\x10"  # loudspeaker_layout (4), output_gain_is_present_flag (1), recon_gain_is_present_flag (1), reserved (2).
       "\x01"  # substream_count.
       "\x01"  # coupled_substream_count.
   },

diff --git a/iamf/cli/testdata/test_000122.textproto b/iamf/cli/testdata/test_000122.textproto
@@ -162,7 +162,7 @@ arbitrary_obu_metadata: [
       "\x01"  # substream_id.
       "\x00"  # num_parameters.
       "\x20"  # num_layers (3), reserved (5)
-      "\xa0"  # loudspeaker_layout (4), output_gain_is_present_flag (1), reserved (2).
+      "\xa0"  # loudspeaker_layout (4), output_gain_is_present_flag (1), recon_gain_is_present_flag (1), reserved (2).
       "\x01"  # substream_count.
       "\x01"  # coupled_substream_count.
   },

diff --git a/iamf/cli/testdata/test_000129.textproto b/iamf/cli/testdata/test_000129.textproto
@@ -163,10 +163,10 @@ arbitrary_obu_metadata: [
       "\x02"  # substream_id[1].
       "\x00"  # num_parameters.
       "\x60"  # num_layers (3), reserved (5)
-      "\x10"  # loudspeaker_layout (4), output_gain_is_present_flag (1), reserved (2).
+      "\x10"  # loudspeaker_layout (4), output_gain_is_present_flag (1), recon_gain_is_present_flag (1), reserved (2).
       "\x01"  # substream_count.
       "\x01"  # coupled_substream_count.
-      "\xa0"  # loudspeaker_layout (4), output_gain_is_present_flag (1), reserved (2).
+      "\xa0"  # loudspeaker_layout (4), output_gain_is_present_flag (1), recon_gain_is_present_flag (1), reserved (2).
       "\x01"  # substream_count.
       "\x01"  # coupled_substream_count.
   },