Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pm: adapt oma package manager #20

Merged
merged 1 commit into from
Jul 17, 2024
Merged

pm: adapt oma package manager #20

merged 1 commit into from
Jul 17, 2024

Conversation

eatradish
Copy link
Member

If oma install has failed, fallback to apt

@what-the-diff
Copy link

what-the-diff bot commented Aug 16, 2023

PR Summary

  • New Function Implementation
    A function named install_from_repo_oma() has been added. This function installs packages using a specific command oma install -y --force-confnew.

  • Function Modification
    The function install_from_repo() is updated to use the newly implemented install_from_repo_oma(), if necessary.

  • Fallback Handling
    The system now can fall back to use the traditional apt-get install when install_from_repo_oma() fails to install packages using oma.

  • Warning Message
    In case of fallback scenario, the application will log a warning if the apt-get install command fails and will attempt to fix the package manager states.

  • Function Update
    The install_from_repo() function is now designed to return None.

  • Exception Handling Enhancement
    Exception handling in install_from_repo_oma() is updated to capture any exception and return False should the oma install command fail.

  • Log Message Improvement
    System now has improved log messaging to indicate when oma fails to install dependencies and has to fallback to apt.

@eatradish
Copy link
Member Author

@what-the-diff[bot] 好厉害……

If oma install has failed, fallback to apt
@MingcongBai MingcongBai merged commit 851ab7d into production Jul 17, 2024
1 check passed
@KexyBiscuit KexyBiscuit deleted the acbs-adapt-oma branch July 21, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants