Skip to content

Commit

Permalink
fix(ci): use secrets for Docker Hub credentials
Browse files Browse the repository at this point in the history
Updated the GitHub Actions workflow to use secrets for Docker Hub
username and password instead of hardcoding them. This enhances
security by keeping sensitive information out of the repository.
  • Loading branch information
Brian2074 committed Nov 10, 2024
1 parent f65361b commit b39e259
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ jobs:
- name: Log in to Docker Hub
uses: docker/login-action@v2
with:
username: "brian247" # Docker Hub username stored in secrets
password: "Lian238@Docker" # Docker Hub password stored in secrets
username: ${{ secrets.DOCKER_USERNAME }} # Docker Hub username stored in secrets
password: ${{ secrets.DOCKER_PASSWORD }} # Docker Hub password stored in secrets

# Step 3: Build Docker image
- name: Build Docker image
Expand Down

0 comments on commit b39e259

Please sign in to comment.