Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for test cases #531

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Fix for test cases #531

merged 6 commits into from
Oct 30, 2024

Conversation

kevin-thankyou-lin
Copy link
Contributor

What this does

Fixes to pass jaco gripper test, linear interpolation, variable impedance tests.

zhuyifengzju
zhuyifengzju approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@zhuyifengzju zhuyifengzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests all passed on my side. Note that for running test_all_renderes.py on mac, it needs to be on mjpython. Otherwise it will not work. But this is a very specific thing to launch_passive for mac.

snasiriany
snasiriany approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@snasiriany snasiriany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read thru code, LGTM

@snasiriany snasiriany merged commit 2dc23ed into master Oct 30, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuyifengzju zhuyifengzju zhuyifengzju approved these changes

@snasiriany snasiriany snasiriany approved these changes

@yukezhu yukezhu Awaiting requested review from yukezhu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevin-thankyou-lin @snasiriany @zhuyifengzju