Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminate mjviewer on resets #591

Merged
merged 2 commits into from
Dec 16, 2024
Merged

terminate mjviewer on resets #591

merged 2 commits into from
Dec 16, 2024

Conversation

snasiriany
Copy link
Contributor

What this does

Fixes #555

In the reset function, destory the viewer if it's mjviewer

How it was tested

Ran the tests in the tests folder, and collect_human_demonstrations.py

SECTION TO REMOVE BEFORE SUBMITTING YOUR PR

Note: Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR. Try to avoid tagging more than 3 people.

Note: Before submitting this PR, please read the contributor guideline.

@kevin-thankyou-lin kevin-thankyou-lin merged commit 8f64e15 into master Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viewer freezes after second reset
2 participants