Refactor CLI Enums to use clap::ValueEnum
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillt
reviewed
Apr 10, 2024
Signed-off-by: Tarek <[email protected]>
Instead of explicitly using `--<FLAG>=true`, use `--flag` Signed-off-by: Tarek <[email protected]>
tareknaser
force-pushed
the
entry_value_enum
branch
from
84d0464 to
86c3729
Compare
Benchmark for 4eb9b5dClick to view benchmark
|
kirillt
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change automatically prints the possible values to the user in the help message
This PR includes changes from ARK-Builders/ark-cli#25