fs-storage implemented trait for conflict resolution
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump arklib version * Added tokio to deal with futures * Updating the index when links are added * Update GitHub Actions --------- Co-authored-by: Alvi Hysa <[email protected]>
Signed-off-by: Tarek <[email protected]>
Signed-off-by: Tarek <[email protected]>
The branch `ark-rust_hot_fix` contains a hot fix where we use the same commit specified when writing `ark-cli` but with pinning `image` crate to the correct version so that `ark-rust` can compile This is just a hot fix. `arklib` shouldn't be even a dependency of any `ark-rust` crate. See #15 for more information Signed-off-by: Tarek <[email protected]>
Signed-off-by: Pushkar Mishra <[email protected]>
tareknaser
added a commit
to tareknaser/ark-rust
that referenced
this pull request
Apr 9, 2024
Signed-off-by: Tarek <[email protected]>
tareknaser
added a commit
to tareknaser/ark-rust
that referenced
this pull request
Apr 9, 2024
Signed-off-by: Tarek <[email protected]>
kirillt
pushed a commit
that referenced
this pull request
Apr 10, 2024
Signed-off-by: Tarek <[email protected]>
Benchmark for b6a7374Click to view benchmark
|
twitu
reviewed
May 23, 2024
fs-storage/src/file_storage.rs
Outdated
|
|
||
| file_storage.set("key1".to_string(), "value1".to_string()); | ||
| assert_eq!(file_storage.is_storage_updated().unwrap(), false); | ||
| //todo: we need to add 1ms delays to make the test pass |
There was a problem hiding this comment.
Perhaps I was too eager in making set immediately sync the file system. It'll be more useful to allow the library user to decide whether they want to write to disk immediately after setting a value or use a different strategy like batching writes.
Once write_fs is moved out of set this test will also be valid.
Signed-off-by: pushkarm029 <[email protected]>
Benchmark for 639d612Click to view benchmark
|
kirillt
reviewed
May 23, 2024
kirillt
reviewed
May 23, 2024
kirillt
reviewed
May 23, 2024
tareknaser
reviewed
May 24, 2024
Signed-off-by: pushkarm029 <[email protected]>
Benchmark for b19bd6aClick to view benchmark
|
Signed-off-by: pushkarm029 <[email protected]>
Benchmark for 47f2e17Click to view benchmark
|
tareknaser
reviewed
May 24, 2024
Signed-off-by: pushkarm029 <[email protected]>
Benchmark for fcadd60Click to view benchmark
|
Signed-off-by: pushkarm029 <[email protected]>
Benchmark for e6b12bdClick to view benchmark
|
twitu
approved these changes
May 25, 2024
|
Last change:
|
kirillt
approved these changes
May 25, 2024
|
Thanks @Pushkarm029 and @twitu as well as @tareknaser! Great team work 👍 |
Benchmark for 2058a72Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on:
fs-storage: Conflicts resolution (Monoid/CRDTs) #19This PR introduces
merge_fromfunction that merges entries of local mapping and another one. Value with clashing keys are merged using the Monoid instance provided by the storage.