Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Note for Benchmarks' Profiles in README #33

Merged
merged 2 commits into from
May 11, 2024
Merged

Add a Note for Benchmarks' Profiles in README #33

merged 2 commits into from
May 11, 2024

Conversation

tareknaser
Copy link
Collaborator

Resolves #40
Related issue: ARK-Builders/arklib#30

Copy link

Benchmark for 5302be6

Click to view benchmark
Test Base PR %
../test-assets/lena.jpg/compute_bytes 13.3±0.05µs 13.4±0.23µs +0.75%
../test-assets/test.pdf/compute_bytes 107.7±0.99µs 107.6±0.44µs -0.09%
compute_bytes_large/compute_bytes 135.8±0.89µs 138.9±1.39µs +2.28%
compute_bytes_medium/compute_bytes 26.9±0.18µs 26.9±0.28µs 0.00%
compute_bytes_small/compute_bytes 127.5±2.67ns 127.3±1.58ns -0.16%
index_build/index_build/../test-assets/ 159.1±0.55µs 157.8±1.28µs -0.82%

@kirillt
Copy link
Member

kirillt commented Apr 28, 2024

@tareknaser have you encountered this error?

...
    Finished bench [optimized + debuginfo] target(s) in 32.70s

dtrace: system integrity protection is on, some features will not be available
dtrace: failed to initialize dtrace: DTrace requires additional privileges

failed to sample program
  1. I guess, the privileges problem can be worked around by using sudo. Although that's not great solution.
  2. What is system integrity in dtrace?

@tareknaser
Copy link
Collaborator Author

I've noticed the same problem on my Mac.

Found this information online:
"On all current MacOS versions, System Integrity Protection (SIP) is enabled by default and prevents most uses of dtrace and other tools and scripts based on it (i.e. dtruss)"

@kirillt
Copy link
Member

kirillt commented May 5, 2024

@tareknaser so if I understand correctly, benchmarking on macOS is only possible after restarting in recovery mode...

image

https://developer.apple.com/documentation/security/disabling_and_enabling_system_integrity_protection

@kirillt
Copy link
Member

kirillt commented May 5, 2024

@tareknaser it seems there is another recipe which allows to restart in recovery mode only once: https://forums.developer.apple.com/forums/thread/17452

Could you validate this instruction?

@tareknaser
Copy link
Collaborator Author

benchmarking on macOS is only possible after restarting in recovery mode

Added a note with possible solutions to the issue

Copy link

github-actions bot commented May 5, 2024

Benchmark for 2898f65

Click to view benchmark
Test Base PR %
../test-assets/lena.jpg/compute_bytes 13.4±0.04µs 13.3±0.17µs -0.75%
../test-assets/test.pdf/compute_bytes 129.9±1.16µs 111.3±1.05µs -14.32%
compute_bytes_large/compute_bytes 163.8±5.21µs 139.4±2.53µs -14.90%
compute_bytes_medium/compute_bytes 28.2±0.25µs 26.9±0.61µs -4.61%
compute_bytes_small/compute_bytes 129.6±1.24ns 130.2±2.58ns +0.46%
index_build/index_build/../test-assets/ 157.4±0.72µs 159.1±0.98µs +1.08%

@tareknaser tareknaser merged commit c87108b into main May 11, 2024
2 checks passed
@tareknaser tareknaser deleted the profiling branch May 11, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate profiles for index construction
2 participants