-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEBUGINFRA-724] Migrate to GitHub Actions #466
Conversation
Migrate to GutHub Actions from Jenkins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good, there are opportunities to reduce the code by using a matrix job. I see many repeated steps across the jobs.
|
||
- name: Build R | ||
run: | | ||
export CXX=clang++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use a job-level env var for that as an alternative.
- name: Get Python modules | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install numpy Pillow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can be more git-friendly by:
pip install \
numpy \
Pillow
- name: Get Python modules | ||
run: | | ||
python -m pip install --upgrade pip | ||
pip install numpy Pillow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
Applied standard repo settings: https://confluence.arm.com/display/DTP/GitHub+Repo+Settings |
Migrate to GitHub Actions from Jenkins.
Two workflows have been created:
build-test: Runs when a pull request is created or updated
post-weekly-release: Runs when