Skip to content

Commit

Permalink
Merge pull request #307 from ASFHyP3/update-mypy-options
Browse files Browse the repository at this point in the history
upgrade to mypy action v0.15.0
  • Loading branch information
jtherrmann authored Jan 18, 2025
2 parents 5144ac1 + 62dc9fe commit 2457c12
Showing 3 changed files with 12 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/static-analysis.yml
Original file line number Diff line number Diff line change
@@ -12,4 +12,4 @@ jobs:
uses: ASFHyP3/actions/.github/workflows/reusable-ruff.yml@v0.14.0

call-mypy-workflow:
uses: ASFHyP3/actions/.github/workflows/reusable-mypy.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-mypy.yml@v0.15.0
4 changes: 4 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -99,6 +99,10 @@ warn_unused_ignores = true
warn_unreachable = true
strict_equality = true
check_untyped_defs = true
install_types = true
non_interactive = true
pretty = true
disable_error_code = ["import-untyped"]
exclude = ["/vend/"]

[[tool.mypy.overrides]]
14 changes: 7 additions & 7 deletions src/hyp3_autorift/s1_isce2.py
Original file line number Diff line number Diff line change
@@ -32,8 +32,8 @@ def get_s1_primary_polarization(granule_name):


def process_sentinel1_with_isce2(reference, secondary, parameter_file):
import isce # noqa
from topsApp import TopsInSAR
import isce # noqa: F401, I001
from topsApp import TopsInSAR # type: ignore[import-not-found]
from hyp3_autorift.vend.testGeogrid_ISCE import loadMetadata, runGeogrid
from hyp3_autorift.vend.testautoRIFT_ISCE import generateAutoriftProduct

@@ -438,9 +438,9 @@ def bounding_box(safe, priority='reference', polarization='hh', orbits='Orbits',
lat_limits: list containing the [minimum, maximum] longitudes
"""
import isce # noqa: F401
from contrib.geo_autoRIFT.geogrid import Geogrid
from isceobj.Orbit.Orbit import Orbit
from isceobj.Sensor.TOPS.Sentinel1 import Sentinel1
from contrib.geo_autoRIFT.geogrid import Geogrid # type: ignore[import-not-found]
from isceobj.Orbit.Orbit import Orbit # type: ignore[import-not-found]
from isceobj.Sensor.TOPS.Sentinel1 import Sentinel1 # type: ignore[import-not-found]

frames = []
for swath in range(1, 4):
@@ -501,8 +501,8 @@ def bounding_box(safe, priority='reference', polarization='hh', orbits='Orbits',

def prep_isce_dem(input_dem, lat_limits, lon_limits, isce_dem=None):
import isce # noqa: F401
import isceobj
from contrib.demUtils import createDemStitcher
import isceobj # type: ignore[import-not-found]
from contrib.demUtils import createDemStitcher # type: ignore[import-not-found]

if isce_dem is None:
seamstress = createDemStitcher()

0 comments on commit 2457c12

Please sign in to comment.