Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to mypy action v0.15.0 #307

Merged
merged 2 commits into from
Jan 18, 2025
Merged

upgrade to mypy action v0.15.0 #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d827577
upgrade to mypy action v0.15.0
jtherrmann Jan 18, 2025
62dc9fe
ignore unfound imports
jtherrmann Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/static-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
uses: ASFHyP3/actions/.github/workflows/[email protected]

call-mypy-workflow:
uses: ASFHyP3/actions/.github/workflows/reusable-mypy.yml@v0.14.0
uses: ASFHyP3/actions/.github/workflows/reusable-mypy.yml@v0.15.0
Dismissed Show dismissed Hide dismissed
4 changes: 4 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@ warn_unused_ignores = true
warn_unreachable = true
strict_equality = true
check_untyped_defs = true
install_types = true
non_interactive = true
pretty = true
disable_error_code = ["import-untyped"]
exclude = ["/vend/"]

[[tool.mypy.overrides]]
Expand Down
14 changes: 7 additions & 7 deletions src/hyp3_autorift/s1_isce2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ def get_s1_primary_polarization(granule_name):


def process_sentinel1_with_isce2(reference, secondary, parameter_file):
import isce # noqa
from topsApp import TopsInSAR
import isce # noqa: F401, I001
from topsApp import TopsInSAR # type: ignore[import-not-found]
from hyp3_autorift.vend.testGeogrid_ISCE import loadMetadata, runGeogrid
from hyp3_autorift.vend.testautoRIFT_ISCE import generateAutoriftProduct

Expand Down Expand Up @@ -438,9 +438,9 @@ def bounding_box(safe, priority='reference', polarization='hh', orbits='Orbits',
lat_limits: list containing the [minimum, maximum] longitudes
"""
import isce # noqa: F401
from contrib.geo_autoRIFT.geogrid import Geogrid
from isceobj.Orbit.Orbit import Orbit
from isceobj.Sensor.TOPS.Sentinel1 import Sentinel1
from contrib.geo_autoRIFT.geogrid import Geogrid # type: ignore[import-not-found]
from isceobj.Orbit.Orbit import Orbit # type: ignore[import-not-found]
from isceobj.Sensor.TOPS.Sentinel1 import Sentinel1 # type: ignore[import-not-found]

frames = []
for swath in range(1, 4):
Expand Down Expand Up @@ -501,8 +501,8 @@ def bounding_box(safe, priority='reference', polarization='hh', orbits='Orbits',

def prep_isce_dem(input_dem, lat_limits, lon_limits, isce_dem=None):
import isce # noqa: F401
import isceobj
from contrib.demUtils import createDemStitcher
import isceobj # type: ignore[import-not-found]
from contrib.demUtils import createDemStitcher # type: ignore[import-not-found]

if isce_dem is None:
seamstress = createDemStitcher()
Expand Down
Loading