Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable link checker #341

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Disable link checker #341

merged 1 commit into from
Aug 10, 2023

Conversation

jtherrmann
Copy link
Contributor

Temporarily disables the link checker until #340 is fixed.

@jtherrmann jtherrmann added the bumpless Changes to documentation, CI/CD pipelines, etc that don't affect the project's version label Aug 10, 2023
@jtherrmann jtherrmann requested a review from a team August 10, 2023 19:31

# TODO: switch back to the push trigger if/when this workflow gets fixed; see https://github.com/ASFHyP3/hyp3-docs/issues/340
# on: push
on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it supposed to be on: workflow_dispatch or as written? I haven't done this before it just looks different

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember the exact reason for the syntax, but I copied it from hyp3-flood-monitoring where it has been working.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it's because you can specify inputs to workflow dispatch if you want: https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/

@jtherrmann jtherrmann merged commit b0c9b08 into develop Aug 10, 2023
@jtherrmann jtherrmann deleted the disable-link-checker branch August 10, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bumpless Changes to documentation, CI/CD pipelines, etc that don't affect the project's version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants