Use full URL for submodule #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other repositories for OCR-D use full URLs. Using it here, too, makes it easier to evaluate all dependencies of OCR-D. Signed-off-by: Stefan Weil <[email protected]>
|
@bertsky, could you please merge this trivial PR, too? |
|
The Github presence is just a mirror of the original repo at git.informatik.uni-leipzig.de. What's so bad about the relative URL? |
That's not obvious and undocumented, and as that repository was last updated 3 years ago the one on GitHub is no longer a mirror. OCR-D uses the repository from GitHub, so that one is relevant for OCR-D.
There is nothing bad about relative URLs as long as they work. But the reason why I wrote this PR was dependency tracking for OCR-D. And for that it's easier to have absolute URLs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other repositories for OCR-D use full URLs. Using it here, too, makes it easier to evaluate all dependencies of OCR-D.