New option to show margin #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi,
This new option change the default behavior.
We usually keep default and add conf to change behavior.
It's important to keep default behavior to avoid on update weirds changes for customers.
Ex : use instead DOC2PROJECT_DO_NOT_SHOWW_MARGIN
(and change langs...)
| @@ -154,6 +154,9 @@ | |||
| // Cloner les attributs suppémentaires du document source sur le projet | |||
| _print_on_off('DOC2PROJECT_CLONE_EXTRAFIELDS', $langs->trans('Doc2ProjectCloneExtrafields')); | |||
|
|
|||
| // Afficher la marge sur la page de page du projet | |||
| _print_on_off('DOC2PROJECT_SHOWW_MARGIN', $langs->trans('Doc2ProjectShowMargin')); | |||
There was a problem hiding this comment.
Suggested change
| _print_on_off('DOC2PROJECT_SHOWW_MARGIN', $langs->trans('Doc2ProjectShowMargin')); | |
| _print_on_off('DOC2PROJECT_DO_NOT_SHOWW_MARGIN', $langs->trans('Doc2ProjectShowMargin')); |
| <td><?php echo $langs->trans('Margin'); ?></td> | ||
| <td><?php echo price($marge) ?></td> | ||
| </tr> | ||
| <?php if (!empty($conf->global->DOC2PROJECT_SHOWW_MARGIN)) { ?> |
There was a problem hiding this comment.
Suggested change
| <?php if (!empty($conf->global->DOC2PROJECT_SHOWW_MARGIN)) { ?> | |
| <?php if (empty($conf->global->DOC2PROJECT_DO_NOT_SHOWW_MARGIN)) { ?> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.