Project creation automations #73
Conversation
I left the remnants of the previous implementation in place to minimize the churn in this commit. The automations code has been moved completely to the server side now. The /ui/available-automations API returns the list of automations available for THIS user and the selected project type. We simply display toggles and pass the selected automations back to Imbi. I also removed the ability to create links, select environments, and set URLs from this screen. Most of the links are going to be set via automations in the future since having incorrect links is a problem in current usage. You can easily add them later and I expect that they are more likely to be correct ;)
We no longer need it.
| result.errors.map((err) => { | ||
| err.path.map((field) => { | ||
| if (newValues[field] !== null) { | ||
| errors[field] = err.message | ||
| } | ||
| }) | ||
| }) |
There was a problem hiding this comment.
If these are arrays, this should use forEach instead, map is generating an unnecessary list.
results.errors.forEach((err) => {
err.path.forEach((field) => {
if (newValues[field] !== null) {
errors[field] = err.message
}
})
})There was a problem hiding this comment.
very good point, lemme fix that one.
| function Automation({ automationName, integrationName, automationSlug }) { | ||
| return { | ||
| integrationName, | ||
| automationName, | ||
| automationSlug | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not really sure what the point of this function is since it just returns a copy of what it got as input. Is it so you can have the proptypes defined below?
There was a problem hiding this comment.
I think that was it ... I really wanted to use it in AutomationList.jsx but I never figured out how to make it work nicely. Lemme clean that half-step up as well.
There was a problem hiding this comment.
I think you're looking for
Automation = PropTypes.exact({
automationName: PropTypes.string.isRequired,
automationSlug: PropTypes.string.isRequired,
integrationName: PropTypes.string.isRequired
})
...
AutomationList.propTypes = {
automations: PropTypes.arrayOf(Automation).isRequired,
selectedAutomations: PropTypes.arrayOf(string).isRequired,
setSelectedAutomations: PropTypes.func.isRequired
}There was a problem hiding this comment.
I ended up dropping this altogether since I couldn't come up with a good way to get WebStorm to pay attention to the requirement so at best it results in a runtime explosion in the console and empty toggles on the screen 😞
Maybe I really want typescript here .... if it works with react hooks (eg, useState) that is.
| data.map(({ automation_name, integration_name, automation_slug }) => | ||
| Automation({ | ||
| automationName: automation_name, | ||
| integrationName: integration_name, | ||
| automationSlug: automation_slug | ||
| }) | ||
| ) |
There was a problem hiding this comment.
@in-op can you think of a cleaner way to translate from snake_case to camelCase? I know that there is probably a package for this but I can't bring myself to pull in something like https://www.npmjs.com/package/change-case for this one case... maybe I should just let things be inconsistent
I forgot that about this... it was a half-finished attempt at adding a data class between Project.Create and AutomationList that never really worked out.
This PR replaces the client-side project creation automations with server-side automations. They were moved to the server-side to:
I also removed the ability to set links and available environments during project creation. Many of the links are going to be moved into individual automations to ensure that they are maintained properly. We can add them back if necessary.
This expects to run against a server with AWeber-Imbi/imbi-api#73 applied.