Skip to content

Commit

Permalink
Merge pull request #640 from ong6/Bug-Fix
Browse files Browse the repository at this point in the history
Bug fix
  • Loading branch information
tjtanjin authored Apr 12, 2021
2 parents 6b8a8fb + fcddab9 commit 3712bfa
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -1274,7 +1274,7 @@ The implementation of this request feature is also done in an OOP fashion, where

The UI of imPoster was evolved to be slightly more complex than that of the original address book. This is because due to the nature of our application (which involved the receiving of API responses), we needed a much larger result display that was able to show more information.

As none of our team members had any experience with JavaFX prior to this module, tampering around with the Ui required significant effort. The Ui also had to be frequently revisited as we continued with other aspects of implementation for our project. For example, when the request feature was being worked on, a GIF had to be shown to the user to indicate an API call in-progress, along with a GIF that accompanied error messages. On top of that, additional prettifying of JSON responses also had to be done for information to be shown neatly to the users. To prevent cluttering of the result display, several information were also chosen to be displayed as smaller neat tags at the top of the result display panel.
As none of our team members had any experience with JavaFX prior to this module, tampering around with the UI required significant effort. The UI also had to be frequently revisited as we continued with other aspects of implementation for our project. For example, when the request feature was being worked on, a GIF had to be shown to the user to indicate an API call in-progress, along with a GIF that accompanied error messages. On top of that, additional prettifying of JSON responses also had to be done for information to be shown neatly to the users. To prevent cluttering of the result display, several information were also chosen to be displayed as smaller neat tags at the top of the result display panel.

Eventually, the team got more comfortable with working on the Ui and to that end, an easily extensible feature was also implemented for the Ui through the `toggle` command (which supported the switching of application theme for our users). The implementation of the `toggle` command allowed for new themes to be added through merely adding the name of the new theme in an enum as well as its corresponding css file.
Eventually, the team got more comfortable with working on the UI and to that end, an easily extensible feature was also implemented for the UI through the `toggle` command (which supported the switching of application theme for our users). The implementation of the `toggle` command allowed for new themes to be added through merely adding the name of the new theme in an enum as well as its corresponding css file.

0 comments on commit 3712bfa

Please sign in to comment.