Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted issue #185 #219

Merged
merged 3 commits into from
Nov 11, 2023
Merged

Reverted issue #185 #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09bacb5
Reverted issue #185
LuahJunYang Nov 10, 2023
d245964
Reverted for issue #184
LuahJunYang Nov 10, 2023
ee483d7
Updated checkstyle error from RemovePolicyCommand
LuahJunYang Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/seedu/address/logic/Messages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ public class Messages {
public static final String MESSAGE_PERSONS_LISTED_OVERVIEW = "%1$d person(s) listed!";
public static final String MESSAGE_DUPLICATE_FIELDS =
"Multiple values specified for the following single-valued field(s): ";
public static final String MESSAGE_INVALID_ALPHANUMERIC_INPUT = "Missing/Invalid parameters!"
+ "Only alphanumeric characters are allowed as input for %1S";
public static final String MESSAGE_INVALID_ALPHANUMERIC_INPUT = "Only alphanumeric characters are allowed as input";
public static final String MESSAGE_MISSING_PREFIXES = "Missing Prefixes, please refer to example below";

/**
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/seedu/address/logic/commands/RemovePolicyCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import java.util.Set;

import seedu.address.commons.core.index.Index;
import seedu.address.logic.Messages;
import seedu.address.logic.commands.exceptions.CommandException;
import seedu.address.model.Model;
import seedu.address.model.person.Person;
Expand Down Expand Up @@ -64,6 +63,6 @@
personToEdit.removePolicy(policyToDelete);
model.setPerson(personToEdit, personToEdit);
model.updateFilteredPersonList(PREDICATE_SHOW_ALL_PERSONS);
return new CommandResult(String.format(MESSAGE_DELETE_POLICY_SUCCESS, Messages.format(personToEdit)));
return new CommandResult(String.format(MESSAGE_DELETE_POLICY_SUCCESS, personToEdit));

Check warning on line 66 in src/main/java/seedu/address/logic/commands/RemovePolicyCommand.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/seedu/address/logic/commands/RemovePolicyCommand.java#L66 

Added line #L66 was not covered by tests
}
}
Loading