Update CompleteCommand to only accept either Index or LocalDate #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there was a bug that allowed both arguments to be input together Updated the parser to only allow either one of the arguments but not both at the same time, else the command usage message will be rendered to user. This is to make it clearer to prevent confusing behaviour for the user
Kb-Tay
added
bug
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
============================================
- Coverage 75.67% 75.66% -0.02%
- Complexity 666 667 +1
============================================
Files 101 101
Lines 2154 2153 -1
Branches 227 228 +1
============================================
- Hits 1630 1629 -1
Misses 461 461
Partials 63 63
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
I think it would be good to update the UG to specify the exact behaviour as well, since I'm not too sure exactly which inputs are accepted and which are not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was a bug that allowed both arguments to be input together
Updated the parser to only allow either one of the arguments but not both at the same time, else the command usage message will be rendered to user.
This is to make it clearer to prevent confusing behaviour for the user
Resolves #199