Refactor Complete Command code #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a Complete command descriptor was used to check if user update by date or index. As such, multiple null checks were made Update Complete Command to have subclasses that will execute differently if user input index or date This cleans up code and removes the needs for multiple null checks
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
============================================
+ Coverage 75.68% 75.82% +0.14%
- Complexity 667 671 +4
============================================
Files 101 103 +2
Lines 2155 2147 -8
Branches 228 222 -6
============================================
- Hits 1631 1628 -3
+ Misses 461 459 -2
+ Partials 63 60 -3
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Kb-Tay
commented
Nov 7, 2023
Comment on lines
+30
to
40
| public void testCompleteByIndexSubclass() { | ||
| //valid Index | ||
| Person editedPerson = new PersonBuilder(BENSON).withNullAppointment().build(); | ||
| String expectedMessage = MESSAGE_COMPLETE_SUCCESS; | ||
| CompleteDescriptor completeDescriptor = new CompleteDescriptor(); | ||
| completeDescriptor.setIndex(INDEX_SECOND_PERSON); | ||
| CompleteCommand completeCommand = new CompleteCommand(completeDescriptor); | ||
|
|
||
| Model expectedModel = new ModelManager(new AddressBook(model.getAddressBook()), new UserPrefs()); | ||
| expectedModel.setPerson(model.getFilteredPersonList().get(1), editedPerson); | ||
|
|
||
| CompleteCommand completeCommand = new CompleteByIndex(INDEX_SECOND_PERSON); | ||
|
|
||
| assertCommandSuccess(completeCommand, model, expectedMessage, expectedModel); |
There was a problem hiding this comment.
Not sure if this correct method of doing integration testing for subclasses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a Complete command descriptor was used to check if user update by date or index. As such, multiple null checks were made
Update Complete Command to have subclasses that will execute differently if user input index or date
This cleans up code and removes the needs for multiple null checks