Fix sort command bug and User Guide documentation #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, The sort command has a bug where the ordering of persons with null appointments will change each time the function is called. This bug fix fixes the functionality and causes people will null appointments to be ordered in an arbitrary order based on the previous way the list was sorted. Edits were also made to the user guide to provide further clarification to the ordering of peoples names when sort appointment is called.
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
============================================
- Coverage 75.94% 75.87% -0.08%
Complexity 666 666
============================================
Files 103 103
Lines 2141 2143 +2
Branches 217 217
============================================
Hits 1626 1626
- Misses 459 460 +1
- Partials 56 57 +1
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
sopa301
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, The sort command has a bug where the ordering of persons with null appointments will change each time the function is called. This bug fix fixes the functionality and causes people will null appointments to be ordered in an arbitrary order based on the previous way the list was sorted.
Edits were also made to the user guide to provide further clarification to the ordering of peoples names when sort appointment is called.