Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FindCommandParser #252

Conversation

sopa301
Copy link
Collaborator

@sopa301 sopa301 commented Nov 10, 2023

No description provided.

@sopa301 sopa301 added this to the v1.4 milestone Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #252 (6162387) into master (738042a) will decrease coverage by 0.04%.
Report is 12 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #252      +/-   ##
============================================
- Coverage     75.87%   75.84%   -0.04%     
+ Complexity      666      665       -1     
============================================
  Files           103      103              
  Lines          2143     2140       -3     
  Branches        217      218       +1     
============================================
- Hits           1626     1623       -3     
  Misses          460      460              
  Partials         57       57              
Files Coverage Δ
.../seedu/address/logic/parser/FindCommandParser.java 100.00% <100.00%> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 96.73% <ø> (-0.38%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

@nikele2001 nikele2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikele2001 nikele2001 merged commit da2eab2 into AY2324S1-CS2103T-F12-1:master Nov 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants