Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid handling of data file upon application launch and minor c… #254

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

nikele2001
Copy link

…hanges

@nikele2001 nikele2001 added this to the v1.4 milestone Nov 10, 2023
@nikele2001 nikele2001 linked an issue Nov 10, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #254 (30f1c5b) into master (de79eb6) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #254      +/-   ##
============================================
- Coverage     75.77%   75.56%   -0.21%     
  Complexity      671      671              
============================================
  Files           103      103              
  Lines          2163     2169       +6     
  Branches        219      219              
============================================
  Hits           1639     1639              
- Misses          461      467       +6     
  Partials         63       63              
Files Coverage Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Collaborator

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sopa301 sopa301 merged commit fd687f4 into AY2324S1-CS2103T-F12-1:master Nov 10, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid data in the data file not handled properly
2 participants