-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid day bug #256
Fix invalid day bug #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the good effort. I think the SLAP is done quite well, though the naming could be a bit more intuitive. Some other things I noticed:
- Javadoc for parseAppointment (aptName and aptDate are outdated).
- (Nitpick) The validation for the
Date
and date part ofDateTime
is duplicated. Perhaps we could extract it into a method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the code implemention is good in readability and has appropiate SLAP. However, can make some edits to prevent repetition of code. Can also consider including more test cases to ensure its comprehensiveness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
============================================
- Coverage 75.53% 75.49% -0.04%
- Complexity 670 676 +6
============================================
Files 103 103
Lines 2166 2175 +9
Branches 220 223 +3
============================================
+ Hits 1636 1642 +6
- Misses 467 469 +2
- Partials 63 64 +1
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
fix #241