Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality and add test cases #271

Merged

Conversation

Kb-Tay
Copy link
Collaborator

@Kb-Tay Kb-Tay commented Nov 11, 2023

No description provided.

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #271 (018b906) into master (1477bcd) will increase coverage by 0.09%.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##             master     #271      +/-   ##
============================================
+ Coverage     75.58%   75.67%   +0.09%     
- Complexity      680      684       +4     
============================================
  Files           103      103              
  Lines          2183     2187       +4     
  Branches        223      223              
============================================
+ Hits           1650     1655       +5     
+ Misses          469      468       -1     
  Partials         64       64              
Files Coverage Δ
...a/seedu/address/logic/commands/CompleteByDate.java 100.00% <100.00%> (ø)
.../seedu/address/logic/commands/CompleteByIndex.java 90.00% <100.00%> (ø)
.../seedu/address/logic/commands/CompleteCommand.java 100.00% <ø> (ø)
src/main/java/seedu/address/model/AddressBook.java 85.29% <100.00%> (+0.91%) ⬆️
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 100.00% <100.00%> (ø)
...a/seedu/address/model/person/UniquePersonList.java 90.47% <100.00%> (+0.47%) ⬆️
.../seedu/address/logic/commands/ScheduleCommand.java 59.37% <62.50%> (-1.92%) ⬇️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Collaborator

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sopa301 sopa301 merged commit 5d0773f into AY2324S1-CS2103T-F12-1:master Nov 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants