Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG and PPP #319

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Update DG and PPP #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/DeveloperGuide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ Alternative 2: Create a hashset of Appointments for each Person.

**Aspect: How to implement override prompt**

Alternative 1: Create a separate constructor in CommandResult to handle overriding
Alternative 1(current solution): Create a separate constructor in CommandResult to handle overriding
- Pros:
* Quick solution to the problem
* This "freezes" functionality of the program to force user to acknowledge or cancel the execution of the command
Expand Down
4 changes: 2 additions & 2 deletions docs/team/jylow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Given below are my contributions to the project.
* What it does: Allows the user to perform sorting of list by appointment time and lexicographical order of name.
* Justification: This feature improves the product significantly because a user can more efficiently find clients by name and the proximity of their appointments to view upcoming appointments.
* Highlights: This enhancement creates a base to implement different sorting capabilities in the future through sorting by new comparators. It required an understanding of ObservableList interface and the way the list is being tracked by JavaFX.
* Credits: The feature was implemented by referencing java ObservableList documentation.
* Credits: The feature was implemented by referencing JavaFX ObservableList documentation.

* **New Feature**: Added confirm override window for `schedule` command if person already has a current appointment [\#123](https://github.com/AY2324S1-CS2103T-F12-1/tp/pull/123)
* What it does: Caution a user if he intends to schedule a new appointment when there is already one that is not yet complete.
Expand All @@ -31,7 +31,7 @@ Given below are my contributions to the project.
* Fixed bugs identified during manual testing

* **Contributions to the UG**:
* Added documentation for the features `sort` [\#81](https://github.com/AY2324S1-CS2103T-F12-1/tp/pull/81)
* Added documentation for the feature `sort` [\#81](https://github.com/AY2324S1-CS2103T-F12-1/tp/pull/81)
* Maintained known issues to be solved
* Proofreading of UG and making changes such as standardising terms used throughout the UG.

Expand Down
Loading